Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.9.2: Refactor Hash to Root/bytes32 #596

Merged
merged 2 commits into from
Jan 7, 2020
Merged

0.9.2: Refactor Hash to Root/bytes32 #596

merged 2 commits into from
Jan 7, 2020

Conversation

twoeths
Copy link
Contributor

@twoeths twoeths commented Dec 22, 2019

Goal

+ remove Hash alias of bytes32
+ introduce Root alias of bytes32
+ change roots to Root
+ change non-roots to bytes32

wemeetagain
wemeetagain approved these changes Dec 23, 2019
View reviewed changes
Copy link
Member

@wemeetagain wemeetagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@twoeths twoeths changed the title Refactor Hash to Root/bytes32 0.9.2: Refactor Hash to Root/bytes32 Dec 26, 2019
@mpetrunic
Copy link
Member

This PR need update. cc @tuyennhv

@twoeths
Copy link
Contributor Author

twoeths commented Dec 30, 2019

This PR need update. cc @tuyennhv

Yeah I'm waiting for #600

@twoeths twoeths force-pushed the tuyen/beacon-node-update-0.9.2 branch from 7dfa6fc to 4c6a83a Compare January 3, 2020 04:46
@twoeths twoeths requested a review from mpetrunic January 6, 2020 00:51
@twoeths twoeths force-pushed the tuyen/beacon-node-update-0.9.2 branch from 4c6a83a to 2ad7fcd Compare January 6, 2020 23:27
@mpetrunic mpetrunic merged commit 06529ed into 0.9.x Jan 7, 2020
@mpetrunic mpetrunic deleted the tuyen/beacon-node-update-0.9.2 branch January 7, 2020 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

@mpetrunic mpetrunic Awaiting requested review from mpetrunic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@twoeths @mpetrunic @wemeetagain