Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scummvm: rename if there's version in file name #1303

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

Birdie0
Copy link
Contributor

@Birdie0 Birdie0 commented Dec 26, 2024

In new ScummVM release executable doesn't include version like that was it previous release, i.e. scummvm.exe instead of scummvm-2.9.0.exe. Because of this renaming added in #1124 results in error during installation (it still ends up successful). I think it's probably better to wrap rename command with condition in case user wants to install older version.

Here's installation log without change:

Updating one outdated app:
Updating 'scummvm' (2.8.1 -> 2.9.0)
Downloading new version
Starting download with aria2 ...
Download: Download Results:
Download: gid   |stat|avg speed  |path/URI
Download: ======+====+===========+=======================================================
Download: ff6093|OK  |   5.5MiB/s|C:/Users/User/scoop/cache/scummvm#2.9.0#83bb47a.zip
Download: Status Legend:
Download: (OK):download completed.
Checking hash of scummvm-2.9.0-win32-x86_64.zip ... ok.
Uninstalling 'scummvm' (2.8.1)
Unlinking ~\scoop\apps\scummvm\current
Installing 'scummvm' (2.9.0) [64bit] from 'games' bucket
Loading scummvm-2.9.0-win32-x86_64.zip from cache.
Extracting scummvm-2.9.0-win32-x86_64.zip ... done.
Running pre_install script...Rename-Item: Cannot find path 'C:\Users\User\scoop\apps\scummvm\2.9.0\scummvm-2.9.0.exe' because it does not exist.
done.
Linking ~\scoop\apps\scummvm\current => ~\scoop\apps\scummvm\2.9.0
Creating shortcut for ScummVM (scummvm.exe)
Persisting scummvm.ini
Persisting saves
Persisting themes
Persisting extras
'scummvm' (2.9.0) was installed successfully!

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

scummvm

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@Calinou Calinou added the bug Something isn't working label Dec 29, 2024
Copy link
Owner

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Calinou Calinou merged commit 9520d65 into Calinou:master Dec 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working review-needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants