Skip to content

Latest commit

 

History

History
26 lines (22 loc) · 1.12 KB

Not using upgrade safe contracts in `FsToken` inheritance.md

File metadata and controls

26 lines (22 loc) · 1.12 KB

The FsToken contract is intended to be an upgradeable contract, used behind a proxy (namely, the FsTokenProxy contract).

However, the contracts ERC20Snapshot, ERC20Mintable and ERC20Burnable in the inheritance chain of FsToken are not imported from the upgrade safe library @openzeppelin/contracts-ethereum-package but instead from @openzeppelin/contracts.

Recommendation:

Use the upgrades safe library in this case will ensure the inheritance from Initializable and the other contracts is always linearized as expected by the compiler.


Slide Screenshot

081.jpg


Slide Text

  • OpenZeppelin Audit Futureswap V2 Finding M01
  • Configuration
  • Medium Severity
  • Upgradeable Contract
  • Unsafe Inheritance
  • Inherit -> Upgrade Safe Contracts

References


Tags