This repository has been archived by the owner on Mar 20, 2023. It is now read-only.
[email protected]+ workaround for Random123. #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olupton
force-pushed
the
olupton/nvhpc-abm-random123
branch
from
06f32cf to
9b7cdac
Compare
olupton
force-pushed
the
olupton/nvhpc-abm-random123
branch
from
6281143 to
5c39ad2
Compare
olupton
added a commit
to neuronsimulator/nrn
that referenced
this pull request
Jan 18, 2022
alexsavulescu
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Jan 18, 2022
* [email protected]+ workaround for Random123. * Pass -DR123_USE_INTRIN_H=0 when compiling NEURON sources to appease Random123's compiler-specific detection logic. * Bump CoreNEURON past BlueBrain/CoreNeuron#754.
pramodk
reviewed
Aug 25, 2022
| # (mis)detects nvc++ as nvcc because we pass the -cuda option and we therefore avoid the | ||
| # problem. If GPU support is disabled, we define R123_USE_INTRIN_H=0 to avoid the problem. | ||
| list(APPEND CORENRN_COMPILE_DEFS R123_USE_INTRIN_H=0) | ||
| endif() | ||
| endif() |
There was a problem hiding this comment.
@olupton : FYI - (accidentally) I was trying to use cpu wheel with nvhpc compiler and end-up with this error.
Wonder if this logic needs to be pushed at later stage (in nrnivmodl_core_makefile or similar)
pramodk
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Nov 2, 2022
* Fix warnings in %nvhpc~gpu builds. * Workaround %[email protected]:~gpu Random123+ABM issue by passing -DR123_USE_INTRIN_H=0. CoreNEURON Repo SHA: BlueBrain/CoreNeuron@221ab3b
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mainly add a workaround for an issue in Random123 compiler detection logic with versions 21.11 and newer of the NVHPC compilers.
-DR123_USE_INTRIN_H=0in NVHPC builds with GPU support disabled to avoid Random123 does not cope with ABM feature macros with PGI/NVIDIA compilers. #724, as recommended in Compatibility issues with NVIDIA compilers. DEShawResearch/random123#6.-cuda, which means Random123 treatsnvc++asnvccand we do not see the issue.Closes #724.
See also: neuronsimulator/nrn#1587.
How to test this?
Build with NVHPC 21.11 or newer and GPU support disabled. Without this PR, you should see compilation errors.
Use certain branches for the SimulationStack CI
CI_BRANCHES:NEURON_BRANCH=master,