adding the ability to maintain the placeholder color if desired #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@weotch I added this, which was to solve this issue on Clif https://app.asana.com/0/1199094171432804/1200386443419587/f
Problem:
showImage
does 2 thingsmaintainPlaceholder
which doesn't wrap.vv-placeholder
in the transitionIf you have an opinion on a better way to go about this, or at least how to clean up me needing to render the
.vv-placeholder
element twice, then let me knowThis works locally on clif for me, and passing
maintainPlaceholder
as a prop lets me control this on a component-by-component basis, because I don't want this to happen on say, transparent pngs