Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making GetClientAssertion method public #2112

Merged
merged 4 commits into from
Mar 17, 2023

Conversation

JoshLozensky
Copy link
Contributor

This will support inheritance of ClientAssertionProviderBase so it can be used to make your own ClientAssertionProvider.

jmprieur

This comment was marked as resolved.

jmprieur

This comment was marked as resolved.

@jmprieur jmprieur self-requested a review March 16, 2023 04:34
Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JoshLozensky :shipit:

Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @JoshLozensky

@JoshLozensky JoshLozensky merged commit 9c1a60a into master Mar 17, 2023
@JoshLozensky JoshLozensky deleted the lozensky_ClientAssertionProviderBase_Inheritance branch March 17, 2023 23:57
@jennyf19 jennyf19 added this to the 2.6.0 milestone Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants