Adds Id to Credential Description #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennyf19
reviewed
Sep 6, 2023
src/Microsoft.Identity.Abstractions/ApplicationOptions/CredentialDescription.cs
Show resolved
Hide resolved
jmprieur
reviewed
Sep 6, 2023
| get | ||
| { | ||
| if (_cachedId == null) | ||
| _cachedId = $"{SourceType}_{ReferenceOrValue}"; |
There was a problem hiding this comment.
Is it enough? or does it require $"{SourceType}_{Container}_{ReferenceOrValue}" ?
There was a problem hiding this comment.
ReferenceOrValue can be null, Container can also be null. SourceType will not be null.
Adding Container to the Id will make it stronger. Will update the PR.
There was a problem hiding this comment.
Updated the Id to use Container.
Today, Id property doesn't throw an exception if Container and/or ReferenceOrValue is null. It proceeds to generate a string that Id.Web will use to maintain a semaphore for that Id. Any concerns with this?
src/Microsoft.Identity.Abstractions/ApplicationOptions/CredentialDescription.cs
Show resolved
Hide resolved
jennyf19
approved these changes
Sep 7, 2023
Done |
jmprieur
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new property on CredentialDescription
Summary of the changes
Introduces a unique identifier for a CredenentialDescription object