Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jmprieur/add target462 #49

Merged
merged 6 commits into from
Dec 29, 2022
Merged

Jmprieur/add target462 #49

merged 6 commits into from
Dec 29, 2022

Conversation

jmprieur
Copy link
Contributor

@jmprieur jmprieur commented Dec 29, 2022

Fixes #48 and #45

  • Adds netstandard2.1 (because HttpMethod.Patch is widely used).
  • Adds the Patch methods to IDownstreamRestApi
  • and net462 (to avoid drawing the entiere framework when this
    library is consumed from a library targeting 462)

Dependencies:

dotnet list src\Microsoft.Identity.Abstractions\Microsoft.Identity.Abstractions.csproj package --include-transitive
Project 'Microsoft.Identity.Abstractions' has the following package references
   [net462]:
   Top-level Package                  Requested   Resolved
   > Microsoft.SourceLink.GitHub      1.0.0       1.0.0
   > System.Net.Http                  4.3.4       4.3.4

   Transitive Package                                   Resolved
   > Microsoft.Build.Tasks.Git                          1.0.0
   > Microsoft.SourceLink.Common                        1.0.0
   > System.Security.Cryptography.Algorithms            4.3.0
   > System.Security.Cryptography.Encoding              4.3.0
   > System.Security.Cryptography.Primitives            4.3.0
   > System.Security.Cryptography.X509Certificates      4.3.0

   [netstandard2.0]:
   Top-level Package                     Requested   Resolved
   > Microsoft.SourceLink.GitHub         1.0.0       1.0.0
   > NETStandard.Library           (A)   [2.0.3, )   2.0.3

   Transitive Package                 Resolved
   > Microsoft.Build.Tasks.Git        1.0.0
   > Microsoft.NETCore.Platforms      1.1.0
   > Microsoft.SourceLink.Common      1.0.0

   [netstandard2.1]:
   Top-level Package                  Requested   Resolved
   > Microsoft.SourceLink.GitHub      1.0.0       1.0.0

   Transitive Package                 Resolved
   > Microsoft.Build.Tasks.Git        1.0.0
   > Microsoft.SourceLink.Common      1.0.0

- Adds netstandard2.1 (because HttpMethod.Patch is widely used).
- Adds the Patch methods to IDownstreamRestApi
- and net462 (to avoid drawing the entiere framework when this
library is consumed from a library targeting 462)
- more test coverage.
Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jmprieur jmprieur merged commit 6971747 into main Dec 29, 2022
@jmprieur jmprieur deleted the jmprieur/addTarget462 branch January 30, 2023 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants