Broker refactoring, bugfix and test cases #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayluo
force-pushed
the
broker-refactor
branch
from
6d3b84d to
53e30de
Compare
rayluo
force-pushed
the
broker-refactor
branch
from
53e30de to
b412bdc
Compare
rayluo
force-pushed
the
broker-refactor
branch
from
b412bdc to
4ce6646
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a recent offline discussion on when MSAL shall automatically be fallback to non-broker code path, even if the app opts in to use broker. For example, ADFS and B2C scenarios are considered unsupported by broker (WAM), but ideally MSAL shall not require app developers to opt in to broker conditionally, therefore, MSAL's DevEx (developer experience) is expected to automatically fall back to non-broker code path when appropriate.
MSAL Python did not previously have enough test cases for this, and there was even some discrepancy between the intention above and the actual behavior. This PR adds 6 test cases to inequivalently demonstrate the behaviors. Reviewers can focus on the test cases. There is also an open question on whether the
instance_discovery=Falsescenario shall bypass broker.