Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable public client ROPC via broker #712

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Enable public client ROPC via broker #712

merged 2 commits into from
Jun 20, 2024

Conversation

fengga
Copy link
Contributor

@fengga fengga commented Jun 17, 2024

If use_broker enabled, ROPC flows on windows will call into WAM, on macOS will call MSAL C++ logic.

@fengga fengga requested a review from a team as a code owner June 17, 2024 22:56
@fengga fengga merged commit 12566ba into dev Jun 20, 2024
12 checks passed
@rayluo
Copy link
Collaborator

rayluo commented Jun 21, 2024

Sorry, @fengga , my bad, I forgot to mention that, in general, all broker-relevant changes must be tested locally, rather than solely rely on the test pipeline, because we did not figure out a way to install broker into MSAL Python's current pipeline. (You may also tackle how to setup broker in test pipeline, but no need to do it in this PR.)

In this particular case, since your one-liner change was reverting a previous change, you could also have use Github's blame feature to find the previous change's PR and realize that there was a test case there. That test case is now failing because we changed the implementation now. Please come up with a new PR (can be in this same branch) to adjust that test case, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants