Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback to expires_on when expires_in is absent #519

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Fallback to expires_on when expires_in is absent #519

merged 1 commit into from
Dec 9, 2022

Conversation

rayluo
Copy link
Collaborator

@rayluo rayluo commented Dec 8, 2022

This is useful for App Service's managed identity.

@rayluo rayluo force-pushed the support_expires_on branch from 6e7bd46 to cff23ee Compare December 9, 2022 20:03
@rayluo
Copy link
Collaborator Author

rayluo commented Dec 9, 2022

Thanks for @xiangyan99 's validation!

[11:41 AM] Xiang Yan
Hi Ray, I tested that with the change in TokenCache, now we have correct expires_on value.

@rayluo rayluo merged commit 2cb18f2 into dev Dec 9, 2022
@rayluo rayluo deleted the support_expires_on branch December 9, 2022 20:10
@rayluo rayluo mentioned this pull request Jan 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rayluo