Bubble http exceptions so apps could catch them #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did not (yet?) hear back from @AlmogBentz . @abhidnya13 please help take a look. |
abhidnya13
reviewed
Oct 27, 2020
abhidnya13
reviewed
Oct 27, 2020
abhidnya13
suggested changes
Oct 27, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can likely close #263 .
@AlmogBentz You can install this branch for your smoke testing:
After this patch, when the lower level network-relevant error (came from requests) occurs, they would be bubbled up as-is, therefore you won't see the "Authority would typically be in a format of ..." error message. You could catch them and treat them differently, therefore satisfying your desire to handle different exception differently.