Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the step to execute InstallAndroid.ps1 from the CI pipeline #5066

Merged
merged 6 commits into from
Jan 10, 2025

Conversation

gladjohn
Copy link
Contributor

@gladjohn gladjohn commented Jan 8, 2025

Fixes #5065

This pull request includes several changes to the LibsAndSamples.sln solution file and the removal of the InstallAndroid.ps1 script. The changes primarily involve configuration updates and cleanup.

Configuration updates in LibsAndSamples.sln:

Cleanup:

  • Removed the InstallAndroid.ps1 script from the build directory and its corresponding entry from the LibsAndSamples.sln file. [1] [2]
  • Removed the step to execute InstallAndroid.ps1 from the CI pipeline configuration file build/template-OneBranch-CI-libsandsamples.yaml.

@gladjohn gladjohn marked this pull request as ready for review January 8, 2025 20:04
@gladjohn gladjohn requested a review from a team as a code owner January 8, 2025 20:04
@gladjohn gladjohn requested a review from Copilot January 9, 2025 04:37

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • LibsAndSamples.sln: Language not supported
  • build/InstallAndroid.ps1: Language not supported
@gladjohn gladjohn requested a review from trwalke January 9, 2025 17:11
@gladjohn
Copy link
Contributor Author

gladjohn commented Jan 9, 2025

Hoping we can reduce the build times now

image

@gladjohn gladjohn merged commit 90e8fc9 into main Jan 10, 2025
4 of 6 checks passed
@gladjohn gladjohn deleted the gladjohn-remove-android branch January 10, 2025 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Engineering task] Remove the step to execute InstallAndroid.ps1 from the CI pipeline
3 participants