Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove experimental flag on Managed Identity Claims and Capabilities APIs #4942

Merged
merged 1 commit into from
Sep 25, 2024
+1 −7
Merged

Remove experimental flag on Managed Identity Claims and Capabilities APIs #4942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...ent/Microsoft.Identity.Client/ApiConfig/AcquireTokenForManagedIdentityParameterBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ public AcquireTokenForManagedIdentityParameterBuilder WithForceRefresh(bool forc
/// <returns>The builder to chain .With methods.</returns>
public AcquireTokenForManagedIdentityParameterBuilder WithClaims(string claims)
{
ValidateUseOfExperimentalFeature("WithClaims");
CommonParameters.Claims = claims;
return this;
}
Expand Down
5 changes: 1 addition & 4 deletions src/client/Microsoft.Identity.Client/AppConfig/ManagedIdentityApplicationBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,14 +89,11 @@ internal ManagedIdentityApplicationBuilder WithAppTokenCacheInternalForTest(ITok
/// </summary>
/// <remarks>
/// MSAL will transform these into special claims request. See https://openid.net/specs/openid-connect-core-1_0-final.html#ClaimsParameter for
/// details on claim requests. This is an experimental API. The method signature may change in the future
/// without involving a major version upgrade.
/// details on claim requests.
/// For more details see https://aka.ms/msal-net-claims-request
/// </remarks>
public ManagedIdentityApplicationBuilder WithClientCapabilities(IEnumerable<string> clientCapabilities)
{
ValidateUseOfExperimentalFeature();

if (clientCapabilities != null && clientCapabilities.Any())
{
Config.ClientCapabilities = clientCapabilities;
Expand Down
1 change: 0 additions & 1 deletion .../Microsoft.Identity.Test.Integration.netcore/HeadlessTests/ManagedIdentityTests.NetFwk.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,6 @@ private IManagedIdentityApplication CreateMIAWithProxy(string url, string userAs
builder.Config.AccessorOptions = null;

IManagedIdentityApplication mia = builder
.WithExperimentalFeatures(true)
.WithHttpManager(proxyHttpManager).Build();

return mia;
Expand Down
1 change: 0 additions & 1 deletion tests/Microsoft.Identity.Test.Unit/ManagedIdentityTests/ManagedIdentityTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,6 @@ public async Task ManagedIdentityWithClaimsAndCapabilitiesTestAsync(
SetEnvironmentVariables(managedIdentitySource, endpoint);

var miBuilder = ManagedIdentityApplicationBuilder.Create(ManagedIdentityId.SystemAssigned)
.WithExperimentalFeatures(true)
.WithClientCapabilities(TestConstants.ClientCapabilities)
.WithHttpManager(httpManager);

Expand Down
Loading