Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dont throw for no WwwAuthenticateHeader in Challenge result #4542

Merged
merged 1 commit into from
Jan 24, 2024
Merged

dont throw for no WwwAuthenticateHeader in Challenge result #4542

merged 1 commit into from
Jan 24, 2024

Conversation

SimonCropp
Copy link
Contributor

since SingleOrDefault is used above, i assume might not exist in the values ?

@SimonCropp
Copy link
Contributor Author

or perhaps

string wwwAuthenticate = responseHeaders.GetValues(PKeyAuthConstants.WwwAuthenticateHeader).SingleOrDefault();

should be

string wwwAuthenticate = responseHeaders.GetValues(PKeyAuthConstants.WwwAuthenticateHeader).Single();

???

@bgavrilMS bgavrilMS force-pushed the dont-throw-for-no-WwwAuthenticateHeader-in-Challenge-result branch from 2ac401c to 8d4ff26 Compare January 23, 2024 14:20
@bgavrilMS bgavrilMS force-pushed the dont-throw-for-no-WwwAuthenticateHeader-in-Challenge-result branch from 4ecafaf to d430a97 Compare January 24, 2024 12:42
@bgavrilMS bgavrilMS merged commit d01b12d into main Jan 24, 2024
1 of 4 checks passed
@bgavrilMS bgavrilMS deleted the dont-throw-for-no-WwwAuthenticateHeader-in-Challenge-result branch January 24, 2024 12:43
gladjohn pushed a commit that referenced this pull request Jan 25, 2024
@SimonCropp @GladwinJohnson
dont throw for no WwwAuthenticateHeader in Challenge result (#4542)
f481f5b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gladjohn gladjohn gladjohn approved these changes

@pmaytak pmaytak pmaytak approved these changes

@bgavrilMS bgavrilMS bgavrilMS approved these changes

@neha-bhargava neha-bhargava Awaiting requested review from neha-bhargava

@trwalke trwalke Awaiting requested review from trwalke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SimonCropp @bgavrilMS @pmaytak @gladjohn