Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Further improved runtime of utilities #618

Merged
merged 39 commits into from
Nov 27, 2023
Merged

feat: Further improved runtime of utilities #618

merged 39 commits into from
Nov 27, 2023

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Nov 12, 2023 •
edited
Loading

Description

  1. Improved runtime of Set-ModuleReadMe utility by building all test files per modules using a thread each.

    Impact:

    Runtime of test runs before change on module 'Cognitive Services'

    1. 20 s
    2. 17 s
    3. 18 s
    4. 17 s
    5. 17 s

    Runtime of test runs after change on module 'Cognitive Services'

    1. 11 s
    2. 9 s
    3. 9 s
    4. 10 s
    5. 10 s
Pipeline
avm.res.key-vault.vault

AlexanderSehr and others added 26 commits November 7, 2023 22:23
@AlexanderSehr
Added skeleton
20ac8b7
@AlexanderSehr
Implemented first new tests
4939b4d
@AlexanderSehr
Changed to warning
4e1d86f
@AlexanderSehr
Expanded test verbosity & added additional tets
94fff0b
@AlexanderSehr
Finalized further tests
c18ce6b
@AlexanderSehr
Update to latest
a343694
@AlexanderSehr
Update to latest
3a6f0a2
@AlexanderSehr
Added module name + small fix
4ab6a5b
@AlexanderSehr
Fixed kvlt
9bb64bd
@AlexanderSehr
Small caching fix
68e2bd2
@AlexanderSehr
Small fix and enabled passthru of warnings to GH
1a013c2
@AlexanderSehr
More updates
1c2fc8a
@AlexanderSehr
Update to latest
d9c6dd5
@AlexanderSehr
Updated test names
dd0c343
@AlexanderSehr
JSON rollback
2ebd458
@AlexanderSehr
Updated regex
f6caf7e
@AlexanderSehr
Removed assertion
f56f66a
@AlexanderSehr
Update to latest
282b640
@AlexanderSehr @eriqua
Update avm/utilities/pipelines/staticValidation/compliance/module.tes…
c025f52 
…ts.ps1

Co-authored-by: Erika Gressi <[email protected]>
@AlexanderSehr @eriqua
Update avm/utilities/pipelines/staticValidation/compliance/module.tes…
405901a 
…ts.ps1

Co-authored-by: Erika Gressi <[email protected]>
@AlexanderSehr
Merge branch 'main' into users/alsehr/testFileCompliance
904c82f
@AlexanderSehr
Rollback of unrelated changes
ef24d1f
@AlexanderSehr
Merge branch 'Azure:main' into main
9393aa1
@AlexanderSehr
Merge branch 'Azure:main' into main
cb39086
@AlexanderSehr
Merge branch 'Azure:main' into main
89eac40
@AlexanderSehr
Added multi-threading to readme script
439fcb7
@AlexanderSehr AlexanderSehr self-assigned this Nov 12, 2023
@AlexanderSehr AlexanderSehr added the Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue label Nov 12, 2023
@AlexanderSehr AlexanderSehr marked this pull request as ready for review November 17, 2023 08:52
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner November 17, 2023 08:52
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) November 17, 2023 08:52
@AlexanderSehr AlexanderSehr mentioned this pull request Nov 20, 2023
Merged
4 tasks
eriqua
eriqua approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 83fde1a into Azure:main Nov 27, 2023
9 checks passed
@AlexanderSehr AlexanderSehr deleted the users/alsehr/readMeSpeadup branch November 27, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexanderSehr @eriqua