[DRAFT] Client invocation for management sdk #2119
Conversation
|
@microsoft-github-policy-service agree company="Microsoft" |
| var message = AppendMessageTracingId(new ClientCompletionMessage(result.InvocationId, connectionId, _callerId, "", new ReadOnlyMemory<byte>())); | ||
| await WriteAsync(message); |
There was a problem hiding this comment.
Is this still needed? In serverless case, service need to know this is a paired CompletionMessage then send back, meanwhile it should be able to cleanup local directly without information from the caller.
| // When the caller server is also the client router, Azure SignalR service won't send a ServiceMappingMessage to server. | ||
| // To handle this condition, CallerClientResultsManager itself should record this mapping information rather than waiting for a ServiceMappingMessage sent by service. Only in this condition, this method is called with instanceId != null. |
There was a problem hiding this comment.
modify the comment to fit serverless scenario.
| } | ||
| } | ||
|
|
||
| public bool TryCompleteResult(string connectionId, ClientCompletionMessage message) |
There was a problem hiding this comment.
I think Service can send back original CompletionMessage directly. Below methods are not really fit serverless and should throw NotSupportedException.
TryCompleteResult(ConnectionId, ClientCompletionMessage)
TryCompleteResult(ConnectionId, ErrorCompletionMessage)
AddServiceMapping()
| internal sealed class WeakClientInvocationManager : IClientInvocationManager | ||
| { | ||
| public ICallerClientResultsManager Caller { get; } | ||
| public IRoutedClientResultsManager Router { get; } |
There was a problem hiding this comment.
Throw directly without assign a dummy router manager?
There was a problem hiding this comment.
Removed the dummy router manager.
Summary of the changes (Less than 80 chars)