Add group member query service message protocol #2118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Y-Sindo
force-pushed
the
presenceMessage
branch
2 times, most recently
from
edd412c to
2f63cd3
Compare
vicancy
reviewed
Jan 2, 2025
src/Microsoft.Azure.SignalR.Protocols/ServiceProtocolConstants.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.SignalR.Protocols/Models/GroupMemberQueryResponsePayload.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.SignalR.Management/HubContext/GroupManager.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.SignalR.Protocols/Models/GroupMemberQueryResponsePayload.cs
Outdated
Show resolved
Hide resolved
Y-Sindo
force-pushed
the
presenceMessage
branch
from
2f63cd3 to
065fedb
Compare
vicancy
reviewed
Jan 6, 2025
Y-Sindo
force-pushed
the
presenceMessage
branch
from
78568cb to
68e8a85
Compare
vicancy
reviewed
Jan 6, 2025
src/Microsoft.Azure.SignalR.Protocols/Models/ServiceModelProtocol.cs
Outdated
Show resolved
Hide resolved
Y-Sindo
force-pushed
the
presenceMessage
branch
from
321538a to
5105939
Compare
vicancy
approved these changes
Jan 7, 2025
Y-Sindo
force-pushed
the
presenceMessage
branch
from
f2532c2 to
0947122
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To implement group member query API in persistent mode, we need to add a mechanism to respond with binary payload from service.
ServiceProtocolto a separate util classMessagePackUtils, so that they could be reused by other classes.string messagemember inAckMessageand addPayloadmember. Thestring messagemember is never used.IMessagePackSerializableinterface, so that we could put the (de)serialization methods of model classes inside themselves.AckHandlerto allow acking with binary payload