Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1ES] Migrate Scale Metrics to Azure.Data.Tables #10276

Merged
merged 17 commits into from
Aug 27, 2024

Conversation

cjaliaga
Copy link
Member

@cjaliaga cjaliaga commented Jul 9, 2024

This PR migrates the Scale Metrics table storage repository to use Azure.Data.Tables instead Microsoft.Azure.Cosmos.Table

Issue describing the changes in this PR

resolves #10166

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

@cjaliaga
Copy link
Member Author

cjaliaga commented Jul 9, 2024

Not ready yet, pending:

  1. Check what's the best way to migrate the delegating handler usage as the new SDK by default will use a shared HttpClientTransport (same HttpClient) and we might need to pass the HttpClient configured with our DelegatingHandler to the TableServiceClient.

  2. Deploy the Private SiteExtension and test some scenarios

@cjaliaga cjaliaga marked this pull request as ready for review July 9, 2024 22:27
@cjaliaga cjaliaga requested a review from a team as a code owner July 9, 2024 22:27
@mathewc
Copy link
Member

mathewc commented Jul 9, 2024

Not ready yet, pending:

  1. Check what's the best way to migrate the delegating handler usage as the new SDK by default will use a shared HttpClientTransport (same HttpClient) and we might need to pass the HttpClient configured with our DelegatingHandler to the TableServiceClient.
  2. Deploy the Private SiteExtension and test some scenarios

I see. When a PR isn't ready, it's good to mark it as a draft so reviewers know. I converted it to draft just now.

@mathewc mathewc marked this pull request as draft July 9, 2024 23:37
@jviau
Copy link
Contributor

jviau commented Jul 10, 2024

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@cjaliaga cjaliaga force-pushed the cjaliaga/scale-metric-10166 branch from 017bf51 to 1c55c7a Compare July 23, 2024 10:26
@cjaliaga cjaliaga marked this pull request as ready for review July 25, 2024 23:08
@fabiocav fabiocav requested review from mathewc and fabiocav July 31, 2024 20:10
@kshyju kshyju self-requested a review August 14, 2024 20:18
@cjaliaga cjaliaga force-pushed the cjaliaga/scale-metric-10166 branch from aebd702 to c749eb3 Compare August 19, 2024 17:17
@Azure Azure deleted a comment from cjaliaga Aug 21, 2024
@fabiocav fabiocav merged commit 44489a3 into dev Aug 27, 2024
10 checks passed
@fabiocav fabiocav deleted the cjaliaga/scale-metric-10166 branch August 27, 2024 23:59
@cjaliaga cjaliaga linked an issue Aug 30, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consolidate scale metrics table client with shared services Migrate Scale Metrics to Azure.Data.Tables
6 participants