{Misc.} Remove all occurrences of assertNotEquals #29120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onlined
requested review from
kairu-ms,
zhoxing-ms,
jsntcy,
yanzhudd,
jiasli,
evelyn-ys,
calvinhzy and
necusjz
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
added
the
customer-reported
onlined
changed the title
onlined
force-pushed
the
remove-assert-not-equals
branch
from
c001443 to
a8beeaa
Compare
Python 3.12 removes assertNotEquals, so we are removing the uses by replacing it by assertNotEqual.
onlined
force-pushed
the
remove-assert-not-equals
branch
from
a8beeaa to
86edf13
Compare
|
@bebound Why was this put back into the backlog? It's not a breaking change. |
3 tasks
|
The removal of
|
jiasli
approved these changes
Jul 15, 2024
jiasli
reviewed
Jul 15, 2024
| @@ -378,7 +378,7 @@ def test_live_event_update(self, storage_account_for_create): | |||
|
|
|||
| self.assertIsNotNone(live_event_updated['crossSiteAccessPolicies']['crossDomainPolicy']) | |||
| self.assertIsNotNone(live_event_updated['crossSiteAccessPolicies']['clientAccessPolicy']) | |||
|
|
|||
There was a problem hiding this comment.
BTW, I always hate trailing whitespace (#27243).
zhoxing-ms
approved these changes
Jul 15, 2024
yanzhudd
approved these changes
Jul 15, 2024
kairu-ms
approved these changes
Jul 16, 2024
bebound
approved these changes
Jul 16, 2024
bebound
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Python 3.12 removes
assertNotEquals, so we are removing the uses by replacing it byassertNotEqual.This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.