Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ARM swagger to subfolder #3533

Closed
wants to merge 1 commit into from
Closed

Conversation

petrkotas
Copy link
Member

Which issue this PR addresses:

The PR prepares the ARORP ARM API for the inclusion of HCP RP in the ARM manifest folder.
It moves the files to openshiftclusters subfolder and updates automatic generation accordingly.

Fixes

What this PR does / why we need it:

Test plan for issue:

Is there any documentation that needs to be updated for this PR?

How do you know this will function as expected in production?

@mociarain
Copy link
Collaborator

/azp run ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

mociarain
mociarain previously approved these changes Apr 24, 2024
Copy link
Collaborator

@mociarain mociarain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand the full implications of this but if it's just re-structuring things then it LGTM

Copy link
Collaborator

@anshulvermapatel anshulvermapatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/api/v20220904/generate.go Outdated Show resolved Hide resolved
kimorris27
kimorris27 previously approved these changes May 24, 2024
@petrkotas
Copy link
Member Author

/azp run ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@github-actions github-actions bot added the needs-rebase branch needs a rebase label Jun 4, 2024
Copy link

github-actions bot commented Jun 4, 2024

Please rebase pull request.

To add new HCP RP the ARO RP is moved
into the subfolder openshiftclusters.

There are no additional changes, no
impact on the SDK and clients.
@tiguelu
Copy link
Contributor

tiguelu commented Aug 30, 2024

Closing. This PR has been moved to #3805

@tiguelu tiguelu closed this Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants