Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gt-e2e: always click close after inserting block on mobile #93220

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

heavyweight
Copy link
Contributor

@heavyweight heavyweight commented Aug 2, 2024

For mobile viewports we are always waiting for the block inserter to automatically close before we click on the close icon.
Since we need to explicitly close the block inserter after adding a block, this check adds a lot of extra execution time to our e2e tests.

Related to #
#92945

Proposed Changes

  • Avoid waiting to the inserter to automatically close

Why are these changes being made?

  • To avoid unnecessary waiting in our e2e tests

Testing Instructions

$VIEWPORT_NAME="mobile" TEST_ON_ATOMIC="true" GUTENBERG_EDGE=true yarn workspace wp-e2e-tests test --group=gutenberg --maxWorkers=1 --workerIdleMemoryLimit=1GB
*

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@heavyweight heavyweight marked this pull request as ready for review August 2, 2024 16:45
@heavyweight heavyweight merged commit b2dad60 into trunk Aug 2, 2024
13 checks passed
@heavyweight heavyweight deleted the fix/e2e-mobile-inserter-close branch August 2, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants