Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: Improve preview menu selector #93144

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Conversation

heavyweight
Copy link
Contributor

@heavyweight heavyweight commented Jul 31, 2024

The preview button selector needs to be updated to work for roles menuitem and menuitemradio to improve the e2e tests.

Related to #
#92945

Proposed Changes

  • Update preview button selector

Why are these changes being made?

  • To have a fix for the nightly build e2e tests

Testing Instructions

Running these should pass:

VIEWPORT_NAME="desktop" ATOMIC_VARIATION="default" TEST_ON_ATOMIC="true" GUTENBERG_EDGE=true yarn workspace wp-e2e-tests test test/e2e/specs/editor/editor__post-basic-flow.ts
TEST_ON_ATOMIC=true GUTENBERG_NIGHTLY=true yarn workspace wp-e2e-tests debug test/e2e/specs/editor/editor__post-basic-flow.ts

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@heavyweight heavyweight merged commit a0f8380 into trunk Jul 31, 2024
13 checks passed
@heavyweight heavyweight deleted the fix/e2e-gt-menu-selector branch July 31, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant