E2E test: Only expand the post summary section if it exists since the summary section will no longer be expansible

[olaseni]

GB is making some new adjustments. See this tracking issue for more context.

At this point, in this commit and PR, the Summary section has been slightly re-imagined and is no longer expansible.

To this end, the concerned e2e tests will be slightly adjusted as the atomic nightlies are beginning to fail. We'll check the existence of that section before we attempt to expand it. This fixes the issue temporarily. Eventually the line to expand that section should be removed in the future.

======= Failed test run #1 ==========
  locator.getAttribute: Timeout 30000ms exceeded.
  =========================== logs ===========================
  waiting for locator('body.block-editor-page').locator('[aria-label="Editor settings"] .components-panel__body-title button:has-text("Summary")')
  ============================================================
  at EditorSettingsSidebarComponent.getAttribute (/home/teamcity-1/buildAgent/work/c4a9d5b38c1dacde/packages/calypso-e2e/src/lib/components/editor-settings-sidebar-component.ts:149:31)
      at EditorSettingsSidebarComponent.expandSection (/home/teamcity-1/buildAgent/work/c4a9d5b38c1dacde/packages/calypso-e2e/src/lib/components/editor-settings-sidebar-component.ts:122:8)
      at EditorPage.schedule (/home/teamcity-1/buildAgent/work/c4a9d5b38c1dacde/packages/calypso-e2e/src/lib/pages/editor-page.ts:756:3)
      at Object.<anonymous> (/home/teamcity-1/buildAgent/work/c4a9d5b38c1dacde/test/e2e/specs/editor/editor__schedule.ts:66:4)

---

Testing instructions

Running e2e tests for Calypso

cd test/e2e
yarn jest --clearCache && yarn build  # clear build cache before each run


GUTENBERG_NIGHTLY=1 TEST_ON_ATOMIC=true yarn jest specs/editor/editor__schedule.ts
VIEWPORT_NAME=mobile GUTENBERG_NIGHTLY=1 TEST_ON_ATOMIC=true yarn jest specs/editor/editor__schedule.ts

GUTENBERG_NIGHTLY=1 TEST_ON_ATOMIC=true yarn jest specs/editor/editor__page-basic-flow.ts
VIEWPORT_NAME=mobile GUTENBERG_NIGHTLY=1 TEST_ON_ATOMIC=true yarn jest specs/editor/editor__page-basic-flow.ts

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-107785

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-107785&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-107785&env=a8c-for-agencies

[matticbot]

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

[fredrikekelund]

This works as expected 👍 I left one inline remark where I'll leave the decision to you, @olaseni.

Moreover, for the testing instructions, it looks like the environment variable should be VIEWPORT_NAME and not VIEWPORT.

[fredrikekelund]

Not saying this approach is wrong, but I'm still curious if you considered adding something like an expandSummary method for this specific case? I'm guessing we don't foresee any specific opportunities to reuse expandSectionIfExists, and having a dedicated expandSummary method might clarify that it can be removed in the future.

[olaseni]

but I'm still curious if you considered adding something like an expandSummary method for this specific case?

Sounds more to-the-point. I like it.

[olaseni]

Moreover, for the testing instructions, it looks like the environment variable should be VIEWPORT_NAME and not VIEWPORT.

Instructions updated.

I keep pasting those instructions around with little adjustments because there are mostly similar. I must have missed it in one of those instances.

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/e2e-update-tests-to-compensate-for-post-summary-that-is-no-longer-collapsible on your sandbox.