-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make change log entries mandatory with every PR #988
Conversation
It looks like Gardening Bot adds the Docs label whenever Changelog gets updated :) |
yep ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it!
That's a bug! :) It shouldn't be happening, we designed the action to ignore changes to I'll look into why that's happening and get this fixed. Edit: PR is here: |
Maybe this is an opportunity to switch to using It is currently used in the Jetpack monorepo as well as in the WooCommerce monorepo, and can be used to generate single changelog entries for each PR, and then update a single changelog file on release. Once the package is in use in the repo, it can be used from the command line when you're working on your PRs, or directly from the PR description, as you can see from the PR template in the WooCommerce repo: Is that something you'd be interested in? I'd be happy to set that up. |
@obenland do you think this is ready to merge? |
Looks likes it needs a new approval. Feel free to merge at your convenience |
It's a pretty barebones way to make sure changelogs get updated with every PR, instead of someone having to go through and doing it manually.
Adding the "Skip Changelog" to a PR will make the check pass, regardless of whether a changelog was updated or not.
Proposed changes: