Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Application: Use Rest Controller structure #1145

Open
wants to merge 8 commits into
base: trunk
Choose a base branch
from
Open

Application: Use Rest Controller structure #1145

wants to merge 8 commits into from

Conversation

obenland
Copy link
Member

@obenland obenland commented Jan 9, 2025 •
edited
Loading

Follow-up to #1146.

Separates concerns with the Server class and makes it a more general REST API plugin.
Future steps could include creating a signature-specific controller that contains verify_signature() and endpoints can inherit from.

Proposed changes:

  • Creates new Application controller including schema.
  • Adds unit tests for the new controller

Other information:

  • Have you written new tests for your changes, if applicable?

@obenland obenland added [Type] Janitorial Skip Changelog Disables the "Changelog Updated" action for PRs where changelog entries are not necessary. labels Jan 9, 2025
@obenland obenland requested a review from a team January 9, 2025 22:40
@obenland obenland self-assigned this Jan 9, 2025
@obenland obenland changed the base branch from trunk to update/webfinger-endpoint January 9, 2025 22:40
@pfefferle
Copy link
Member

There seem to be a unittest error

@pfefferle
Copy link
Member

Wrong title?

@obenland obenland force-pushed the update/webfinger-endpoint branch 2 times, most recently from fb179b5 to 662bf16 Compare January 10, 2025 14:58
@obenland obenland changed the base branch from update/webfinger-endpoint to update/webfinger-rest-api January 10, 2025 15:34
@obenland obenland changed the title Webfinger: Use Rest Controller structure Application: Use Rest Controller structure Jan 10, 2025
Base automatically changed from update/webfinger-rest-api to trunk January 10, 2025 19:09
@obenland obenland force-pushed the add/application-controller branch from 7abcf49 to 79d0eec Compare January 10, 2025 19:50
@obenland
Bring back some of the icon definition
fba566f 
This reverts commit 0ee0142.

This is meant to describe the endpoint response, not the Activitypub object
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfefferle pfefferle pfefferle left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@obenland obenland

Labels
Skip Changelog Disables the "Changelog Updated" action for PRs where changelog entries are not necessary. [Type] Janitorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@obenland @pfefferle