Init new custom mailer class #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I forgot to load the mailer And added some line breaks
pfefferle
added
the
Skip Changelog
pfefferle
removed
the
Skip Changelog
obenland
requested changes
Dec 10, 2024
Co-authored-by: Konstantin Obenland <[email protected]>
Co-authored-by: Konstantin Obenland <[email protected]>
Co-authored-by: Konstantin Obenland <[email protected]>
obenland
previously approved these changes
Dec 10, 2024
pfefferle
commented
Dec 11, 2024
Comment on lines
+180
to
186
| $message = \sprintf( \esc_html__( 'New Direct Message: %2$s', 'activitypub' ), \esc_html( get_option( 'blogname' ) ), \wp_strip_all_tags( $activity['object']['content'] ) ) . "\r\n\r\n"; | ||
| /* translators: Actor name */ | ||
| $message .= \sprintf( \esc_html__( 'From: %s', 'activitypub' ), \esc_html( $actor['name'] ) ) . "\r\n"; | ||
| /* translators: Actor URL */ | ||
| $message .= \sprintf( \esc_html__( 'URL: %s', 'activitypub' ), \esc_url( $actor['url'] ) ) . "\r\n\r\n"; | ||
|
|
||
| \wp_mail( $email, $subject, $message ); |
There was a problem hiding this comment.
Should we support HTML mails for direct messages?
Suggested change
| $message = \sprintf( \esc_html__( 'New Direct Message: %2$s', 'activitypub' ), \esc_html( get_option( 'blogname' ) ), \wp_strip_all_tags( $activity['object']['content'] ) ) . "\r\n\r\n"; | |
| /* translators: Actor name */ | |
| $message .= \sprintf( \esc_html__( 'From: %s', 'activitypub' ), \esc_html( $actor['name'] ) ) . "\r\n"; | |
| /* translators: Actor URL */ | |
| $message .= \sprintf( \esc_html__( 'URL: %s', 'activitypub' ), \esc_url( $actor['url'] ) ) . "\r\n\r\n"; | |
| \wp_mail( $email, $subject, $message ); | |
| $message = \sprintf( \esc_html__( 'New Direct Message: %2$s', 'activitypub' ), \esc_html( get_option( 'blogname' ) ), \wp_kses( $activity['object']['content'] ) ) . "<br/><br/>"; | |
| /* translators: Actor name */ | |
| $message .= \sprintf( \esc_html__( 'From: %s', 'activitypub' ), \esc_html( $actor['name'] ) ) . "<br/>"; | |
| /* translators: Actor URL */ | |
| $message .= \sprintf( \esc_html__( 'URL: %s', 'activitypub' ), \esc_url( $actor['url'] ) ) . "<br/><br/>"; | |
| \wp_mail( $email, $subject, $message, array( 'Content-Type: text/html' ) ); |
There was a problem hiding this comment.
this is not working code, just to show how it might be possible!
There was a problem hiding this comment.
I think it's fine as is for now.
obenland
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to load the mailer 🫣
And added some line breaks
Bonus: Direct-Messages
Fix #1012