-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an early return filter for get_upload_dir()
#1008
Conversation
@mattwiebe you also have to add the changelog entry to the readme.txt, then the tests are green! |
It does not like me 😆 |
We could also probably just scrap the regular filter entirely. I doubt anyone was using it, since it was just for us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that you accidentally bring back a lot of readme stuff!
I quickly fixed it
Thanks! The conflict resolution thing here was acting all kinds of weird for me |
Our use of
wp_upload_dir()
inActivitypub\get_upload_baseurl()
was creating PHP warnings on dotcom due to its internal use ofwp_mkdir_p()
which fails there.Fixes #
Proposed changes:
pre_activitypub_get_upload_baseurl
filter to bypass the use ofwp_upload_dir()