Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have better checks if audience should be set or not #1002

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

pfefferle
Copy link
Member

Should help with issue: LemmyNet/lemmy#5147

@pfefferle pfefferle requested a review from mattwiebe November 18, 2024 13:49
@pfefferle pfefferle requested a review from akirk November 19, 2024 15:23
@pfefferle pfefferle merged commit ace8e4a into trunk Nov 20, 2024
21 checks passed
@pfefferle pfefferle deleted the improve/audience-handling branch November 20, 2024 08:24
@harcesz
Copy link

harcesz commented Dec 5, 2024

Could a blog be used a single user and still have an audience? Or to be more precise; would be possible to allow setting a single user blog so it shows up as a community in Lemmy, rather than a user? From my tests on the current version it does not seem to work.

@pfefferle
Copy link
Member Author

Not out of the box, but I can help with a code snippet that overrides the person type with group.

@harcesz
Copy link

harcesz commented Dec 5, 2024

That would be much appreciated! Also such a setting would be great in future versions :)

@pfefferle
Copy link
Member Author

pfefferle commented Dec 6, 2024

I got very controversial feedback because of the Group implementation and tweaked that a lot for that special usecase (Blog-User + Users enabled). I am not sure if I want to make it a setting, because it might break things if you do not exactly know what you are doing, especially on Friendi.ca!

@harcesz
Copy link

harcesz commented Dec 8, 2024

Uh, yeah, who'd expect the social network protocol to have to deal with groups of people ;P But still - understood.

I'd appreciate the mentioned snippet if you think generally I can use it without exploding anyones server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants