-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Add Jetpack Tiled Gallery block square layout #20831
[RNMobile] Add Jetpack Tiled Gallery block square layout #20831
Conversation
* The Jetpack Tiled Gallery block can be added from the native mobile editor via the block picker. * Multiple images can be added using the native mobile image picker.
Caution: This PR has changes that must be merged to WordPress.com |
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. 🔴 Action required: Please add missing changelog entries for the following projects: Use the Jetpack CLI tool to generate changelog entries by running the following command: Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
db0ac55
to
3ec4ba6
Compare
I'm closing this PR because all changes found in this PR have either been merged into the |
Addresses wordpress-mobile/gutenberg-mobile#3874
Ports the Jetpack Tiled Gallery block to Mobile Gutenberg. It is part of a group of PRs, including this one. They are:
Please note: This PR is currently a work-in-progress implementation and is incomplete (e.g. it does not yet contain changelog changes, PR checks will fail, etc).
Changes proposed in this Pull Request:
InnerBlocks
API, to follow the Gallery block's recent refactor to useInnerBlocks
Jetpack product discussion
TO-DO
Does this pull request change what data or activity we track or use?
TO-DO
Testing instructions:
TO-DO