Fix tokenless authentication chart #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@larsxschneider: Please have a look at my changes. I hope that you’re okay with the look-ahead solution. What it does is capture the I’m still thinking whether we could simply support GitHub Enterprise 2.11 by extending the |
pluehne
force-pushed
the
patrick/fix-tokenless-auth-chart
branch
2 times, most recently
from
e099d98 to
75d12e3
Compare
The format of the gitauth.log file changed from GitHub Enterprise 2.11 to 2.12. This makes it necessary to adjust the regular expression responsible for fetching user names and repositories. Unfortunately, it seems that we can no longer rely on the order of the fields in gitauth.log. For this reason, multiple grep iterations are performed and the regular expression is changed to use look-aheads to allow for arbitrary field orders. For backward compatibility with GitHub Enterprise 2.11 and earlier, a switch is implemented that executes the old query if necessary.
pluehne
force-pushed
the
patrick/fix-tokenless-auth-chart
branch
from
75d12e3 to
ecfddb4
Compare
|
@larsxschneider: I implemented the backward compatibility check, and this pull request is now ready for review 😄. |
larsxschneider
approved these changes
Mar 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The format of the
gitauth.logfile changed from GitHub Enterprise 2.11 to 2.12. This makes it necessary to adjust the regular expression responsible for fetching user names and repositories.Unfortunately, it seems that we can no longer rely on the order of the fields in gitauth.log. For this reason, multiple grep iterations are performed and the regular expression is changed to use look-aheads to allow for arbitrary field orders.
For backward compatibility with GitHub Enterprise 2.11 and earlier, a switch is implemented that executes the old query if necessary.
Addresses the second issue mentioned in #139.