Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more mouse over? #62

Closed
toddocon opened this issue Dec 14, 2017 · 8 comments
Closed

No more mouse over? #62

toddocon opened this issue Dec 14, 2017 · 8 comments
Labels

Comments

@toddocon
Copy link
Contributor

I just updated to the latest Hubble and now I no longer have mouse over information like mousing over bubbles or the bands in the collaboration charts.

I also reloaded the site in Safari in a new private window, I see the same behavior.

@toddocon
Copy link
Contributor Author

toddocon commented Dec 14, 2017

And links is also broken. This would include Organization names and ORG/repo links in the API requests table, etc...

We had only changed 3 files locally for site specific settings. There was one conflict for docs/_config.yml (the URL of course). All other changes merged fine.

@pluehne
Copy link
Contributor

pluehne commented Dec 14, 2017

I can reproduce this on http://autodesk.github.io/hubble/.

Also, data series can’t be hidden or shown. It seems that no mouse events are passed to the JavaScript-rendered charts anymore, including the tables.

@pluehne pluehne added the bug label Dec 14, 2017
@filmaj
Copy link
Contributor

filmaj commented Dec 14, 2017

I think this is related to the spinner I added (#59) - the container element housing the spinner stays on top of the graph, preventing any mouse over interactions.

I'll have a PR w/ a fix shortly.

@pluehne
Copy link
Contributor

pluehne commented Dec 14, 2017

@filmaj: No worries, and thanks for taking care of this 👍!

filmaj added a commit to filmaj/hubble that referenced this issue Dec 14, 2017
… to spinner container getting in the way. this ensures we remove the container as well as the spinner once chart data is loaded.
@filmaj
Copy link
Contributor

filmaj commented Dec 14, 2017

Fix for this is available in #63

@larsxschneider
Copy link
Collaborator

@toddocon: @filmaj fixed it! Can you check on your end?

@toddocon
Copy link
Contributor Author

Just merged with latest Hubble. Confirmed, this is fixed now. Thank you all.

@filmaj
Copy link
Contributor

filmaj commented Dec 14, 2017

😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants