Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return 200 for POST v1/traces #5962

Merged
merged 1 commit into from
Jan 9, 2025
Merged

fix: return 200 for POST v1/traces #5962

merged 1 commit into from
Jan 9, 2025

Conversation

RogerHYang
Copy link
Contributor

@RogerHYang RogerHYang commented Jan 9, 2025 •
edited
Loading

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 9, 2025
mikeldking
mikeldking approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@mikeldking mikeldking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@RogerHYang RogerHYang merged commit 421852b into main Jan 9, 2025
58 checks passed
@RogerHYang RogerHYang deleted the return-200-for-v1-traces branch January 9, 2025 04:02
@mikeldking mikeldking mentioned this pull request Jan 8, 2025
Merged
@RogerHYang RogerHYang mentioned this pull request Jan 9, 2025
Closed
@RogerHYang RogerHYang linked an issue Jan 9, 2025 that may be closed by this pull request
[BUG] POST /v1/traces returns 204 not 200 #5963
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeldking mikeldking mikeldking approved these changes

Assignees
No one assigned
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
phoenix
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] POST /v1/traces returns 204 not 200
2 participants
@RogerHYang @mikeldking