feat(prompts): update prompt version tags on set #5946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XL
cephalization
approved these changes
Jan 8, 2025
Comment on lines
+25
to
+32
| const tags = data.tags.map((tag) => ({ | ||
| id: tag.id, | ||
| name: tag.name, | ||
| })); | ||
| return ( | ||
| <TagGroup aria-label="Prompt Version Tags"> | ||
| <TagList items={tags}>{(tag) => <Tag>{tag.name}</Tag>}</TagList> | ||
| </TagGroup> |
There was a problem hiding this comment.
This map seems extraneous
There was a problem hiding this comment.
yeah it seems that way but in reality the aria-components builds a collection under the hood. Without this it's not wrapped in a collection and it doesn't let you map over tags inside the list. It's weird but how it works.
mikeldking
added a commit
that referenced
this pull request
Jan 9, 2025
* feat(prompts): update prompt version tags on set * remove unnecessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5939
This mostly solves the problem of keeping the tags up to date on a version. It's not clear if this is sufficient to update all the versions' tags. Will follow up on that one. This at least moves the tags ui into a component for now to make the data refreshing easy via a fragment.
Screen.Recording.2025-01-07.at.4.49.43.PM.mov