Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prompts): graphql types for tools, output_schema #5849

Merged
merged 2 commits into from
Dec 30, 2024

Conversation

mikeldking
Copy link
Contributor

@mikeldking mikeldking commented Dec 30, 2024

resolves #5848

{
  prompts {
    edges {
      prompt: node {
        id
        promptVersions {
          edges {
            node {
            	tools {
                definition
              }
            }
          }
        }
      }
    }
  }
}
``

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 30, 2024


@strawberry.type
class JSONSchema:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might be largely un-necessary

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it might be nice to have a "container" for this in case there are non-json schemas?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be valuable so we can union type for Json schema conforming json, vs non conforming json (schema-less)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe something like that yeah

@mikeldking mikeldking merged commit 7a07c18 into prompts Dec 30, 2024
49 checks passed
@mikeldking mikeldking deleted the mikeldking/5848-tools branch December 30, 2024 19:15
mikeldking added a commit that referenced this pull request Dec 31, 2024
* feat(prompts): graphql types for tools, output_schema

* fix types
mikeldking added a commit that referenced this pull request Jan 3, 2025
* feat(prompts): graphql types for tools, output_schema

* fix types
mikeldking added a commit that referenced this pull request Jan 3, 2025
* feat(prompts): graphql types for tools, output_schema

* fix types
mikeldking added a commit that referenced this pull request Jan 9, 2025
* feat(prompts): graphql types for tools, output_schema

* fix types
mikeldking added a commit that referenced this pull request Jan 9, 2025
* feat(prompts): graphql types for tools, output_schema

* fix types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants