-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(prompts): graphql types for tools, output_schema #5849
Conversation
|
||
|
||
@strawberry.type | ||
class JSONSchema: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this might be largely un-necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it might be nice to have a "container" for this in case there are non-json schemas?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be valuable so we can union type for Json schema conforming json, vs non conforming json (schema-less)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe something like that yeah
* feat(prompts): graphql types for tools, output_schema * fix types
* feat(prompts): graphql types for tools, output_schema * fix types
* feat(prompts): graphql types for tools, output_schema * fix types
* feat(prompts): graphql types for tools, output_schema * fix types
* feat(prompts): graphql types for tools, output_schema * fix types
resolves #5848