-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heli autorotation restructure mode and improve speed controller #28209
base: master
Are you sure you want to change the base?
Heli autorotation restructure mode and improve speed controller #28209
Conversation
70cff60
to
05b1cb1
Compare
05b1cb1
to
8ef67b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MattKear This looks good to me. I guess it needs to pass CI before we can merge
} else { | ||
_heliflags.below_land_min_coll = false; | ||
} | ||
_heliflags.below_land_min_coll = !is_positive(collective_out - _collective_land_min_pct); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand what this fixes? It seems like what was there and what you are proposing are the same thing.
…trained to _collective_land_min_pct. Needed to account for FLT_EPSILON.
8ef67b4
to
6198306
Compare
@MattKear I rebased this to see why there were checks failing Just compiled it locally and I received this error. In file included from ../../libraries/AC_Autorotation/AC_Autorotation.cpp:1: |
This PR is the next step in bringing on the autorotation flight mode. It builds on the work done in #27786 and is dependant upon it. Hence, the diff looks very large at the moment.
The following changes have been made:
Testing has been in Real flight only.
The majority of this PR is still behind the SITL only wall.
Special attention should be paid to the changes in AP_MotorsHeli_Single, _Dual & _Quad whereby I have slightly modified the way we detect the collective is on land col min. A modification to the autorotation auto test highlighted that this flag was not tripping when collective was being constrained to land col min. This bit is not SITL only