SITL: added support for up to 32 rotors #27598
Open
+68
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
32 might seem a bit mad, but there is almost no difference in flash cost vs just adding one or two more. We do have a PR to move to 16, #21157. I do think we will need support for more than 12 eventually. |
peterbarker
force-pushed
the
pr-32-rotors
branch
from
9dd9652 to
d667cb2
Compare
peterbarker
force-pushed
the
pr-32-rotors
branch
from
d667cb2 to
fdda608
Compare
IamPete1
reviewed
Jan 6, 2025
| @@ -355,7 +355,7 @@ SRV_Channels::SRV_Channels(void) | |||
| #if NUM_SERVO_CHANNELS > 16 | |||
| if (i >= 16) { | |||
| // default to GPIO, this disables the pin and stops logging | |||
There was a problem hiding this comment.
comment needs a update. Does none still stop logging?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a user asked if we could support up to 32 rotors, so here is a PR that demonstrates flying in SITL with 32 rotors
not really expecting this to be merged as is :-)