Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for installing packages.json dependencies (via npm/yarn install) #22841

Open
1 task done
Angelk90 opened this issue Jan 8, 2025 · 3 comments
Open
1 task done
Labels
enhancement [core label] javascript JavaScript programming language support typescript TypeScript programming language support

Comments

@Angelk90
Copy link
Contributor

Angelk90 commented Jan 8, 2025

Check for existing issues

  • Completed

Describe the feature

It would be nice, if the dependencies are not installed so there is no node_modules folder and there is a package.json file, then via a notification it asks you if you want to install them.

Screenshot 2025-01-08 alle 09 31 52

Zed Version and System Specs

Zed: v0.168.2 (Zed Preview)
OS: macOS 14.1.1
Memory: 16 GiB
Architecture: x86_64

If applicable, add mockups / screenshots to help present your vision of the feature

No response

@Angelk90 Angelk90 added admin read Pending admin review enhancement [core label] triage Maintainer needs to classify the issue labels Jan 8, 2025
@notpeter notpeter changed the title Notification that warns you to install dependencies Support for installing packages.json dependencies (via npm/yarn install) Jan 8, 2025
@notpeter notpeter added typescript TypeScript programming language support javascript JavaScript programming language support and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Jan 8, 2025
@osiewicz
Copy link
Contributor

osiewicz commented Jan 8, 2025

I think it'd be better to handle it on language server side - VTSLS could send out a MessageRequest for pop-up and then install dependencies on server side.

@Angelk90
Copy link
Contributor Author

Angelk90 commented Jan 9, 2025

@osiewicz : You say to check it here:

async fn workspace_configuration(
self: Arc<Self>,
delegate: &Arc<dyn LspAdapterDelegate>,
_: Arc<dyn LanguageToolchainStore>,
cx: &mut AsyncAppContext,
) -> Result<Value> {

@osiewicz
Copy link
Contributor

osiewicz commented Jan 9, 2025

No, I mean that this functionality can be implemented by a language server and we don't need to write any extra code on Zed's side to support it. In fact I think it would make more sense to do it this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement [core label] javascript JavaScript programming language support typescript TypeScript programming language support
Projects
None yet
Development

No branches or pull requests

3 participants