Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression (Preview): active line number no longer highlighted #22734

Open
1 task done
baldwindavid opened this issue Jan 6, 2025 · 0 comments
Open
1 task done

Regression (Preview): active line number no longer highlighted #22734

baldwindavid opened this issue Jan 6, 2025 · 0 comments
Assignees
Labels
bug [core label] editor Feedback for code editing, formatting, editor iterations, etc

Comments

@baldwindavid
Copy link
Contributor

baldwindavid commented Jan 6, 2025

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

In the latest Preview release, the active line number is no longer highlighted. This makes it difficult to see which line is highlighted when navigating search results via the outline panel. This is especially true if the current line highlights are off or with a theme with a subtle background highlight.

Specifically, the theme key editor.active_line_number now seems to be ignored.

This still works in the stable release. I suspect this regressed in #22167.

Zed Version and System Specs

Zed: v0.168.2 (Zed Preview)
OS: macOS 14.4.1
Memory: 32 GiB
Architecture: aarch64

If applicable, add screenshots or screencasts of the incorrect state / behavior

On the left is the Stable release and Preview on the right. Line 11 is the active line in both. Only the line number in the Stable release is highlighted. This was screenshotted in the Andromeda theme, but occurs in all themes.

2025-01-06T202728@2x

@baldwindavid baldwindavid added admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue labels Jan 6, 2025
@danilo-leal danilo-leal self-assigned this Jan 7, 2025
@JosephTLyons JosephTLyons added editor Feedback for code editing, formatting, editor iterations, etc and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug [core label] editor Feedback for code editing, formatting, editor iterations, etc
Projects
None yet
Development

No branches or pull requests

3 participants