Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to_icechunk doesn't have a group option #341

Open
rabernat opened this issue Dec 11, 2024 · 1 comment
Open

to_icechunk doesn't have a group option #341

rabernat opened this issue Dec 11, 2024 · 1 comment
Labels
good first issue Good for newcomers Icechunk 🧊 Relates to Icechunk library / spec

Comments

@rabernat
Copy link
Collaborator

This signature

def dataset_to_icechunk(
ds: Dataset, store: "IcechunkStore", append_dim: Optional[str] = None
) -> None:

should include a group option to allow you to put the dataset somewhere other than at the root of the store hierarchy.

@TomNicholas TomNicholas added Icechunk 🧊 Relates to Icechunk library / spec good first issue Good for newcomers labels Dec 11, 2024
@TomNicholas
Copy link
Member

Right. I think this basically only requires passing the group kwarg down through to where we create the prefix here

key=f"{key_prefix}/c/{chunk_key}", # should be of form 'group/arr_name/c/0/1/2', where c stands for chunks

cc @mpiannucci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Icechunk 🧊 Relates to Icechunk library / spec
Projects
None yet
Development

No branches or pull requests

2 participants