-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to interpret variables using cftime #117
Comments
Just to say that I am taking a look at this. |
Just wanted to add +1 here, since this is quite important for our work to bring virtual zarr access to ESGF (jbusecke/esgf-virtual-zarr-data-access#8). Please let me know if/where I could help test, and ill try to make some time. |
This is still on my radar and I appreciate the nudge. The test is the one thing that I am confident in 😅 it's more the implementation that needs some thought. |
I'm reading up on encodings now. |
It's possible the proper way to implement this is actually to use see #157 for general idea of using xarray to handle CF conventions. |
#68 (comment) explains how we don't currently have support for virtualizing encoded time variables.
To handle this it looks like we need to an another option to
open_virtual_dataset
, acftime_vars
kwarg, which specifies which variables should be interpreted using cftime. (I thinkcftime_vars
should be a subset ofloadable_vars
.) This suggestion comes from how kerchunk deals with this problem:https://fsspec.github.io/kerchunk/reference.html#kerchunk.combine.MultiZarrToZarr
Originally posted by @dcherian in #73 (comment)
The text was updated successfully, but these errors were encountered: