Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV Ingest Columns Server Setting #48

Open
1 task done
MustafaJafar opened this issue Dec 3, 2024 · 0 comments
Open
1 task done

CSV Ingest Columns Server Setting #48

MustafaJafar opened this issue Dec 3, 2024 · 0 comments
Labels
type: maintenance Changes to the code that don't affect product functionality (Technical debt, refactors etc.))

Comments

@MustafaJafar
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues and added correct labels.

Please describe the feature you have in mind and explain what the current shortcomings are?

Currently, CSV Ingest Columns Server Setting is a list where admins can add/remove list items.

  • Some items are required thus removing them from the list can break the creator.
  • We can't add more items without supporting them in the creator logic.

Suggested implementation?

Converting the list to a tuple can make the settings look static but this will require some dev for the settings conversation and also for the creator as currently, it expects a list not a tuple.

It'll also be nice if required toggle in the required columns is disabled so that admins can't alter its value.

a list a tuple
Image Image

Describe alternatives you've considered:

No response

@MustafaJafar MustafaJafar added the type: maintenance Changes to the code that don't affect product functionality (Technical debt, refactors etc.)) label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance Changes to the code that don't affect product functionality (Technical debt, refactors etc.))
Projects
None yet
Development

No branches or pull requests

1 participant