Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot take screenshot #28

Open
ghost opened this issue Aug 18, 2016 · 10 comments
Open

Cannot take screenshot #28

ghost opened this issue Aug 18, 2016 · 10 comments

Comments

@ghost
Copy link

ghost commented Aug 18, 2016

When i use the 'Save in Frost' bookmarklet when im viewing the FROST page then it saves that page. But when i go into other sites and click the bookmarklet it never saves anymore, i dont understand??
Is it adblock plus or something?? i have https and adblock plus and adblocker. But i doubt its not working because of that.

Can someone tell me why this is happening?
Also thank you for this work, the only thing that would be nice, is to have or make folders under FROST, and store the pages in folders, just like the bookmarks window in firefox.

@y-lohse
Copy link
Owner

y-lohse commented Aug 19, 2016

Aw, sorry to hear that. I haven't used it in a while myself, so let's see if I can remember how it works.

I think there was an issue with https sites; can you try to save a non-https site using the bookmarklet to see how that goes?
IIRC, you also need to be logged in to your cozy cloud account within the same browser that uses the bookmarklet. Is that the case?
You also say it doesn't save anymore, did it ever work for you? If so, do you remember when it stopped working?

@ghost
Copy link
Author

ghost commented Aug 19, 2016

ok i tried it with non-https sites and it still doesnt save. Evene tried when logged into another tab.
yes sorry, i didnt mean to say 'anymore' - it never actually worked before. The only page it saves is the site of FROST in Cozy itself.

Does yours work?

My link is this:
javascript:(function(){var%20script=document.createElement('script');script.src='https://192.168.0.5/apps/frost/bm.js?'+Math.floor((+new%20Date)/(864e5));document.body.appendChild(script);})()

@y-lohse
Copy link
Owner

y-lohse commented Aug 19, 2016

Mine worked last time I checked, but it has been a while and my cozy installation is broken right now. My least favourite solution is that a change to the cozy platform may have broken the bookmarklet, but I'd like to rule out other things first.

Now, your link might be wrong. Can you try to open this link please : https://192.168.0.5/apps/frost/bm.js ? It should display a simple javascript file.

@ghost
Copy link
Author

ghost commented Aug 19, 2016

Ok i did that and it displayed some javascript code, but at the end it says

alert("Sorry but your browser doesn't support the Fetch API.");

@y-lohse
Copy link
Owner

y-lohse commented Aug 19, 2016

That's normal :-). Thanks for testing.

If you know how to access the dev tools console in your browser, I'd be curious to know what happens there when you try to use the bookmarklet on a page. If not, no worries, I'll try to reproduce the problem on my machine asap.

@ghost
Copy link
Author

ghost commented Aug 21, 2016

Sorry i not sure how to do that. please let me know when you find out why its not working

@y-lohse
Copy link
Owner

y-lohse commented Aug 28, 2016

Sorry for the delay, I haven't forgotten about this issue, just haven't had time to look into it yet :|

@ghost
Copy link
Author

ghost commented Aug 29, 2016

no problem, let me know :)

@y-lohse
Copy link
Owner

y-lohse commented Oct 12, 2016

Ok, finally took some time to get my cozy back up... and I can't reproduce the problem, it works fairly well for me.

So, I'll need you to try the bookmarklet with the developer console of your browser open. You can open it my pressing ctrl+maj+i, or by doing right click on the page -> inspect element, and then finding a panel called "Console".
Once there, please click on the bookmarklet and something should happen in the console. Could you tell me what?

@y-lohse
Copy link
Owner

y-lohse commented Oct 19, 2016

This issue might be the same as this one : https://forum.cozy.io/t/frost-application/2123/63

It would make sense that in order to inject the script and run the bookmarklet, cookies need to be sent. Not sure how much control I have over this though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant