diff --git a/dotnet/targets/Xamarin.Shared.Sdk.targets b/dotnet/targets/Xamarin.Shared.Sdk.targets index 53d821c05ff..830a7472bb4 100644 --- a/dotnet/targets/Xamarin.Shared.Sdk.targets +++ b/dotnet/targets/Xamarin.Shared.Sdk.targets @@ -8,7 +8,6 @@ - diff --git a/msbuild/Xamarin.MacDev.Tasks/Tasks/FilterStaticFrameworksTaskBase.cs b/msbuild/Xamarin.MacDev.Tasks/Tasks/FilterStaticFrameworksTaskBase.cs index 15652bdd7ef..637113a7b7c 100644 --- a/msbuild/Xamarin.MacDev.Tasks/Tasks/FilterStaticFrameworksTaskBase.cs +++ b/msbuild/Xamarin.MacDev.Tasks/Tasks/FilterStaticFrameworksTaskBase.cs @@ -12,6 +12,8 @@ namespace Xamarin.MacDev.Tasks { // This task takes an itemgroup of frameworks, and filters out frameworks that aren't dynamic libraries. public abstract class FilterStaticFrameworksTaskBase : XamarinTask { + public bool OnlyFilterFrameworks { get; set; } + [Output] public ITaskItem []? FrameworkToPublish { get; set; } @@ -27,6 +29,11 @@ public override bool Execute () frameworkExecutablePath = Path.Combine (frameworkExecutablePath, Path.GetFileNameWithoutExtension (frameworkExecutablePath)); } + if (OnlyFilterFrameworks && !Path.GetDirectoryName (frameworkExecutablePath).EndsWith (".framework", StringComparison.OrdinalIgnoreCase)) { + Log.LogMessage (MessageImportance.Low, $"Skipped processing {item.ItemSpec} because it's not a framework"); + continue; + } + if (!File.Exists (frameworkExecutablePath)) { Log.LogError (158, frameworkExecutablePath, MSBStrings.E0158 /* The file '{0}' does not exist. */, frameworkExecutablePath); continue; diff --git a/msbuild/Xamarin.Shared/Xamarin.Shared.targets b/msbuild/Xamarin.Shared/Xamarin.Shared.targets index 7ed0d06fa98..50d7e9dabbb 100644 --- a/msbuild/Xamarin.Shared/Xamarin.Shared.targets +++ b/msbuild/Xamarin.Shared/Xamarin.Shared.targets @@ -85,6 +85,7 @@ Copyright (C) 2018 Microsoft. All rights reserved. + diff --git a/msbuild/Xamarin.iOS.Tasks.Windows/Xamarin.iOS.HotRestart.targets b/msbuild/Xamarin.iOS.Tasks.Windows/Xamarin.iOS.HotRestart.targets index 76cf4437e64..1c55621cc32 100644 --- a/msbuild/Xamarin.iOS.Tasks.Windows/Xamarin.iOS.HotRestart.targets +++ b/msbuild/Xamarin.iOS.Tasks.Windows/Xamarin.iOS.HotRestart.targets @@ -48,15 +48,25 @@ + + + + + + + - +