Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CSS integration with Gutenberg #875

Open
koke opened this issue Apr 16, 2019 · 0 comments
Open

Improve CSS integration with Gutenberg #875

koke opened this issue Apr 16, 2019 · 0 comments

Comments

@koke
Copy link
Member

koke commented Apr 16, 2019

While developing WordPress/gutenberg#14826 we encountered some issues with CSS and Gutenberg:

  1. Trying to reuse Gutenberg's _variables.scss didn't work, because some of the syntax wasn't accepted in react native (I'm not sure if it was React Native or the sass transformer).
  2. Keeping the different syntax on a native-specific file didn't work either, since stylelint tried to enforce a syntax that wouldn't work on native

From WordPress/gutenberg#14826 (comment)

Having to set a font family via JS is counter-intuitive at the moment since it doesn't follow the rest of the code (setting styles via SCSS) so, it will be best if we track it.

Leaving the discussion of whether we should use CSS for native, as long as we do, there are a couple approaches I can think of:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants