Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local changes detected after undo #896

Open
designsimply opened this issue Feb 23, 2020 · 4 comments
Open

Local changes detected after undo #896

designsimply opened this issue Feb 23, 2020 · 4 comments
Labels

Comments

@designsimply
Copy link

Moved from wordpress-mobile/WordPress-Android#8009. h/t @mzorz

Expected behavior

If content remains identical to what the Editor was fed with, it should not show the Local changes label when adding content then undoing.

Actual behavior

Opening an existing post, adding a character then tapping on undo still makes the app believe there were changes made to the content.

Steps to reproduce the behavior

  1. Open existing post (make sure it's not a post with local changes at this point)
  2. Type a character
  3. Press Undo
  4. Press back and observe "Local Changes" label on the post list
Tested on [Google Pixel], Android [8.1]
@designsimply
Copy link
Author

Moved from wordpress-mobile/WordPress-Android#8009 (comment). h/t @rachelmcr

In my testing, the issue here is that the "undo" action wasn't saved.

When I follow those steps to reproduce the issue, and then open the post again, I can see the changes that I made to the post even though those changes were removed with the "undo" button previously. (This also happens if I type a character and backspace to remove it; the character I added is saved locally.)

@designsimply
Copy link
Author

designsimply commented Feb 23, 2020

Tested and confirmed using 14.2-rc-2 on pixel 3 Android 10. (1m54s)

@hypest
Copy link
Contributor

hypest commented Feb 25, 2020

Is this only happening in the Classic Editor or in mobile Gutenberg too?

@designsimply
Copy link
Author

Good question. I just did a quick test and it's happening in Gutenberg Mobile too. I'll do a bit more testing and create an additional issue in the gutenberg-mobile repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants