Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Refactor line-height properties for ease of use #2584

Closed
Aljullu opened this issue May 28, 2020 · 9 comments
Closed

Refactor line-height properties for ease of use #2584

Aljullu opened this issue May 28, 2020 · 9 comments
Labels
focus: global styles Issues that involve styles/css/layout structure. priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. status: stale Stale issues and PRs have had no updates for 60 days. type: refactor The issue/PR is related to refactoring.

Comments

@Aljullu
Copy link
Contributor

Aljullu commented May 28, 2020

This is a follow-up of #2533 (comment) and #2533 (review).

In #2533 we refactored font size properties but that meant removing line heights from the font-size() mixin. In order to avoid having magic numbers around the code, we could explore other solutions:

  • Adding line-height back to the mixin.
  • Using variables for line-height.
@Aljullu Aljullu added the type: refactor The issue/PR is related to refactoring. label May 28, 2020
@Aljullu Aljullu mentioned this issue May 28, 2020
Merged
@nerrad nerrad added the focus: global styles Issues that involve styles/css/layout structure. label Jun 20, 2020
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Remove the stale label or post a comment, otherwise it will be closed in 10 days.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Dec 12, 2020
@nerrad nerrad added priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. and removed status: stale Stale issues and PRs have had no updates for 60 days. labels Dec 15, 2020
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Feb 15, 2021
@Aljullu Aljullu removed the status: stale Stale issues and PRs have had no updates for 60 days. label Feb 15, 2021
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Apr 17, 2021
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Apr 21, 2021
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Jun 21, 2021
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Jun 25, 2021
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Aug 25, 2021
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Aug 26, 2021
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Oct 27, 2021
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Nov 3, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2022

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Jan 6, 2022
@Aljullu Aljullu removed the status: stale Stale issues and PRs have had no updates for 60 days. label Jan 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2022

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Mar 8, 2022
@Aljullu Aljullu removed the status: stale Stale issues and PRs have had no updates for 60 days. label Mar 8, 2022
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label May 17, 2022
@github-actions github-actions bot closed this as completed Jun 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
focus: global styles Issues that involve styles/css/layout structure. priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. status: stale Stale issues and PRs have had no updates for 60 days. type: refactor The issue/PR is related to refactoring.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nerrad @Aljullu