Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Replace all hardcoded font-color declarations with alternatives in the Cart and Checkout blocks #2459

Closed
Aljullu opened this issue May 11, 2020 · 1 comment · Fixed by #2745
Assignees
Labels
block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. focus: global styles Issues that involve styles/css/layout structure. type: enhancement The issue is a request for an enhancement.

Comments

@Aljullu
Copy link
Contributor

Aljullu commented May 11, 2020

Hardcoded font-color make our blocks not to play well with different background colors: a black text will not be visible if the store has a black background. We should evaluate and implement alternatives depending on each case:

  • Some times, two different font-weight values work as well as two different colors.
  • Some other times, opacity is good enough to simulate different shades of the same color.

Some of this will need design approval/recommendations, so better discuss each change with designers.

@Aljullu Aljullu added the type: enhancement The issue is a request for an enhancement. label May 11, 2020
@Aljullu Aljullu self-assigned this May 22, 2020
@Aljullu Aljullu changed the title Replace all hardcoded font-color declarations with alternatives Replace all hardcoded font-color declarations with alternatives in the Cart and Checkout blocks Jun 17, 2020
@Aljullu
Copy link
Contributor Author

Aljullu commented Jun 17, 2020

Let's rename this issue so it's only about fixing this in the Cart and Checkout blocks. We have another issue to identify other blocks affected by this (#2539).

@Aljullu Aljullu added block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. labels Jun 17, 2020
@nerrad nerrad added the focus: global styles Issues that involve styles/css/layout structure. label Jun 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. focus: global styles Issues that involve styles/css/layout structure. type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants