Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Metadata breaking change from Array to Object #311

Open
KeeedL opened this issue Oct 6, 2024 · 1 comment
Open

[Bug]: Metadata breaking change from Array to Object #311

KeeedL opened this issue Oct 6, 2024 · 1 comment

Comments

@KeeedL
Copy link

KeeedL commented Oct 6, 2024

🔎 Search Terms

Metadata type change

The problem

We were using winston-mongodb 5.1.1 to store our logs.

Trying to upgrade our logger app to winston-mongodb 6.0.0 has broken our reader log app.

Using winston-mongodb 6.0.0, metadata type changed from Array to Object

Our reader log app is currently searching for metadata[index] but as it changes to object, we have to change our reader app but also to handle both type (Array and also Object) for a period.

Is there any way to still save an Array rather than an Object using winston-mongodb 6.0.0 ?

What version of Winston presents the issue?

winston-mongodb v6.0.0

What version of Node are you using?

v20.8.0

If this worked in a previous version of Winston, which was it?

winston-mongodb v5.1.1

Minimum Working Example

No response

Additional information

No response

@DABH
Copy link
Contributor

DABH commented Nov 11, 2024

Breaking changes are allowed with major version bumps :) That being said, if this is a big usability issue for you, feel free to open a PR that would support either an array or object mode for the metadata?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants