Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support local service discovery BEP 14 #44

Closed
RangerMauve opened this issue Jan 28, 2019 · 5 comments · Fixed by #48
Closed

Support local service discovery BEP 14 #44

RangerMauve opened this issue Jan 28, 2019 · 5 comments · Fixed by #48

Comments

@RangerMauve
Copy link

RangerMauve commented Jan 28, 2019

I've been having trouble getting clients to seed to each other either on the same machine or on the same network (on a home network).

Another concern is that the reliance on the DHT / Trackers means that you can't discover peers if you're not connected to the internet at large.

Would a PR that adds support for BEP 14 be welcome?

@epvbergen
Copy link

I'm also very interested in that functionality. However can it work? If webtorrent runs on top of webrtc, local discovery using multicast requires that the browser-based webrtc can join multicast addresses using SDP. Or something in that vein. I've looked at the specs but there's no indication that that is even a thing... I so dearly hope I'm missing something and don't need to bundle some kind of service that would need to be installed.

@RangerMauve
Copy link
Author

Yeah, I think the local discovery would only work in node.js. :(

@pataquets
Copy link

I would love to see this implemented, too.
Even when not working under WebRTC, lots of NodeJS projects use this lib.
This one could benefit, for instance: mafintosh/torrent-stream#204
Big +1 here.

@pataquets
Copy link

@feross Any feedback about @RangerMauve offer? (Or somebody else)

@feross
Copy link
Member

feross commented Nov 4, 2020

Really nice PR to solve this issue from @hicom150 here: #48

@feross feross closed this as completed in #48 Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants